.split() function not handling multiple charcters

blakehartshorn · May 24, 2019, 2:47pm

I’m going to assume this isn’t expected behavior. It’s a bit strange:

Icinga 2 (version: r2.10.4-1)
Type $help to view available commands.
<1> => test = "my.happy.domain.edu"
null
<2> => test.split(".")
[ "my", "happy", "domain", "edu" ]
<3> => test.split("app")
[ "my.h", "", "", "y.dom", "in.edu" ]

It treats each individual character in the provided string as something to remove/separate. I was expecting it to behave more or less like the .split() function in Python. Wanted to check if this was expected behavior before submitting a bug on github.

Sorry to submit this during 2.11 hell D:

dnsmichi · May 24, 2019, 4:04pm

Hi,

an issue is a good idea. The code starts here in case you want to start looking by yourself - I’m back on Monday

github.com

Icinga/icinga2/blob/master/lib/base/string-script.cpp#L57


	return boost::to_upper_copy(self);
}


static String StringLower()
{
	ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
	String self = vframe->Self;
	return boost::to_lower_copy(self);
}


static Array::Ptr StringSplit(const String& delims)
{
	ScriptFrame *vframe = ScriptFrame::GetCurrentFrame();
	String self = vframe->Self;
	std::vector<String> tokens = self.Split(delims.CStr());


	return Array::FromVector(tokens);
}


static int StringFind(const std::vector<Value>& args)
{

Cheers,
Michael

blakehartshorn · May 24, 2019, 5:48pm

If C++ lands in my skillset, I’ll start helping out. For now, I’m going to be a hipster and learn Rust.

blakehartshorn · May 25, 2019, 10:54pm

https://github.com/Icinga/icinga2/issues/7202 Going to resolve this thread since ticket is open.